e2e/tests.bats (1)

345-357: Make this E2E test self-contained to avoid order dependence.

This test depends on suite-prepared state (test-client-oidc, active exporters) and uses jmp delete leases --all, which broadens side effects beyond the lease created here. Please make setup/cleanup local to this test so it can run deterministically in isolation.

Based on learnings: "E2E tests in bats should be runnable in isolation. Do not rely on prior suite setup or shared state across tests."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@e2e/tests.bats` around lines 345 - 357, This test is order-dependent because
it relies on pre-existing client and exporter state and uses a global cleanup;
modify the test to be self-contained by creating and using a unique test client
(instead of relying on "jmp config client use test-client-oidc"), ensure any
required exporter is started or validated with wait_for_exporter, create the
lease with a unique selector/label so it’s identifiable, capture the created
lease identifier from the "jmp create lease" output, assert on "jmp get leases"
as before, and then delete only that specific lease (and the test client) rather
than calling "jmp delete leases --all" so setup and teardown are local to the
test.

python/packages/jumpstarter/jumpstarter/client/grpc_test.py (1)

443-449: Add a deterministic non-expired REMAINING assertion.

Current tests validate expired and None, but not the positive formatting output (Xd Yh Zm). Adding one fixed-clock test would better protect the new display behavior from regressions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@python/packages/jumpstarter/jumpstarter/client/grpc_test.py` around lines 443
- 449, Add a deterministic positive-case test for Lease._format_remaining that
asserts a future datetime produces the expected "Xd Yh Zm" string: create a
fixed "now" (e.g., datetime(2020,1,1,0,0,0)), compute a future time (e.g., now +
timedelta(days=1, hours=2, minutes=3)), call
Lease._format_remaining(future_time) and assert it equals "1d 2h 3m"; add this
as test_format_remaining_future in grpc_test.py and ensure the test uses the
fixed clock (or computes expected output from that fixed reference) so it is
deterministic.

python/packages/jumpstarter/jumpstarter/client/grpc_test.py (1)

443-448: Consider adding a test for future datetime remaining format.

Tests cover the "expired" and "" cases, but there's no explicit test verifying the human-readable remaining duration format (e.g., "2h 15m") for future datetimes. This is the primary use case for the REMAINING column.

💡 Suggested additional test

def test_format_remaining_future(self):
    # Use a datetime far enough in the future to avoid flakiness
    from datetime import timezone
    future = datetime.now(timezone.utc).replace(tzinfo=None) + timedelta(hours=2, minutes=30)
    result = Lease._format_remaining(future)
    # Should return a non-empty human-readable string
    assert result != ""
    assert result != "expired"
    # Optionally verify format contains time units
    assert "h" in result or "m" in result or "d" in result

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@python/packages/jumpstarter/jumpstarter/client/grpc_test.py` around lines 443
- 448, Add a test named test_format_remaining_future that calls
Lease._format_remaining with a datetime sufficiently in the future (e.g.,
datetime.now() + timedelta(hours=2, minutes=30)) to avoid flakiness; assert the
return is not empty, not "expired", and contains at least one time unit
character like "h", "m", or "d" to verify the human-readable remaining-duration
format produced by Lease._format_remaining.